Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export SelectPanel draft from @primer/react/drafts #3809

Merged
merged 4 commits into from
Oct 13, 2023

Conversation

gr2m
Copy link
Contributor

@gr2m gr2m commented Oct 11, 2023

Changelog

New

  • the new SelectPanel draft component can be imported like this

    import { SelectPanel } from '@primer/react/drafts'

Changed

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan

Testing & Reviewing

I was looking for some kind of smoke test to verify what components are exported but couldn't find it. If one exists I'd add a test that verifies that SelectPanel can be imported from @primer/react/drafts found it 🤦🏼

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews (Storybook)
  • Changes are SSR compatible
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@gr2m gr2m requested review from a team and siddharthkp October 11, 2023 04:29
@changeset-bot
Copy link

changeset-bot bot commented Oct 11, 2023

🦋 Changeset detected

Latest commit: 1bec8cf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@gr2m gr2m force-pushed the export-select-panel-from-drafts branch from 16eed67 to 00bad03 Compare October 11, 2023 04:31
@github-actions
Copy link
Contributor

github-actions bot commented Oct 11, 2023

size-limit report 📦

Path Size
dist/browser.esm.js 104.74 KB (0%)
dist/browser.umd.js 105.32 KB (0%)

@github-actions github-actions bot temporarily deployed to storybook-preview-3809 October 11, 2023 04:35 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3809 October 11, 2023 04:36 Inactive
@gr2m gr2m temporarily deployed to github-pages October 11, 2023 04:37 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3809 October 11, 2023 04:38 Inactive
Copy link
Member

@broccolinisoup broccolinisoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @gr2m 👋🏻 When we export any component, we also update the export tests (mainly to snapshot what is exported from which bundle) - could you please run npm run test -- -u and commit the snapshot changes?

@gr2m gr2m temporarily deployed to github-pages October 11, 2023 05:01 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3809 October 11, 2023 05:01 Inactive
@gr2m
Copy link
Contributor Author

gr2m commented Oct 11, 2023

could you please run npm run test -- -u and commit the snapshot changes?

already did via 6f15574, shortly before you commented. Sorry that I missed that at first

@gr2m
Copy link
Contributor Author

gr2m commented Oct 11, 2023

note to self: I can test this PR by installing a pre-release

bin/npm i @primer/[email protected] -w npm-workspaces/primer

I'll do that first to make sure it works. If it all works I'll merge it in.

@gr2m
Copy link
Contributor Author

gr2m commented Oct 12, 2023

I tested it and it worked! This is ready to be merged and released 🙏🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants