-
Notifications
You must be signed in to change notification settings - Fork 538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
export SelectPanel
draft from @primer/react/drafts
#3809
Conversation
🦋 Changeset detectedLatest commit: 1bec8cf The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
16eed67
to
00bad03
Compare
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @gr2m 👋🏻 When we export any component, we also update the export tests (mainly to snapshot what is exported from which bundle) - could you please run npm run test -- -u
and commit the snapshot changes?
already did via 6f15574, shortly before you commented. Sorry that I missed that at first |
note to self: I can test this PR by installing a pre-release
I'll do that first to make sure it works. If it all works I'll merge it in. |
I tested it and it worked! This is ready to be merged and released 🙏🏼 |
Changelog
New
the new
SelectPanel
draft component can be imported like thisChanged
Removed
Rollout strategy
Testing & Reviewing
I was looking for some kind of smoke test to verify what components are exported but couldn't find it. If one exists I'd add a test that verifies thatfound it 🤦🏼SelectPanel
can be imported from@primer/react/drafts
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.