Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(react): remove support for testing React 17 #3800

Merged
merged 5 commits into from
Oct 12, 2023

Conversation

joshblack
Copy link
Member

@joshblack joshblack commented Oct 9, 2023

Starting in v36, we will support only React 18. This PR removes these checks in current main as we look to merge in next-major over the next couple of weeks 👀

Changelog

New

Changed

Removed

  • Remove test and type-check matrices in CI workflow
  • Remove REACT_VERSION_LATEST and REACT_VERSION_17 flags from Jest config and tests

Rollout strategy

We will need to update the protected branch for main to expect test and type-check instead of the 17 and 18 suffixed jobs that we currently have. Once that's complete, we can merge in the PR and update all other PRs to inherit the new workflow jobs.

Testing & Reviewing

  • Verify that the test and type-check jobs appear and pass
  • Verify that the test and type-check jobs with (17) and (18) appended to them do not run

@changeset-bot
Copy link

changeset-bot bot commented Oct 9, 2023

⚠️ No Changeset found

Latest commit: 0a054bf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2023

size-limit report 📦

Path Size
dist/browser.esm.js 104.74 KB (0%)
dist/browser.umd.js 105.32 KB (0%)

@joshblack joshblack added the skip changeset This change does not need a changelog label Oct 9, 2023
@joshblack joshblack temporarily deployed to github-pages October 9, 2023 21:21 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3800 October 9, 2023 21:21 Inactive
@joshblack joshblack marked this pull request as ready for review October 10, 2023 17:40
@joshblack joshblack requested review from a team and siddharthkp October 10, 2023 17:40
@joshblack joshblack temporarily deployed to github-pages October 10, 2023 17:44 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3800 October 10, 2023 17:45 Inactive
@joshblack joshblack temporarily deployed to github-pages October 12, 2023 16:07 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3800 October 12, 2023 16:08 Inactive
@joshblack joshblack added this pull request to the merge queue Oct 12, 2023
Merged via the queue into main with commit 341243f Oct 12, 2023
28 of 29 checks passed
@joshblack joshblack deleted the ci/remove-react-17-ci-checks branch October 12, 2023 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset This change does not need a changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants