Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add image support to Pillar component #862

Merged
merged 29 commits into from
Dec 20, 2024

Conversation

danielguillan
Copy link
Contributor

@danielguillan danielguillan commented Dec 12, 2024

Summary

Adds support to include an image as part of the Pillar component.

List of notable changes:

  • Added <Pillar.Image>.
  • Updated interface guidelines and React docs.
  • Updated the bottom margin of images to ensure consistency across Pillars and Cards.

Steps to test:

Supporting resources (related issues, external links, etc):

Contributor checklist:

  • All new and existing CI checks pass
  • Tests prove that the feature works and covers both happy and unhappy paths
  • Any drop in coverage, breaking changes or regressions have been documented above
  • UI Changes contain new visual snapshots (generated by adding update snapshots label to the PR)
  • All developer debugging and non-functional logging has been removed
  • Related issues have been referenced in the PR description

Reviewer checklist:

  • Check that pull request and proposed changes adhere to our contribution guidelines and code of conduct
  • Check that tests prove the feature works and covers both happy and unhappy paths
  • Check that there aren't other open Pull Requests for the same update/change

Copy link

changeset-bot bot commented Dec 12, 2024

🦋 Changeset detected

Latest commit: 688442f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@primer/react-brand Patch
@primer/brand-primitives Patch
@primer/brand-e2e Patch
@primer/brand-fonts Patch
@primer/brand-config Patch
@primer/brand-storybook Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Dec 12, 2024

🟢 No design token changes found

Copy link
Contributor

github-actions bot commented Dec 12, 2024

🟢 No visual differences found

Our visual comparison tests did not find any differences in the UI.

@natalie-iv
Copy link

@jesussandreas could you please take a look. we had that discussion in Slack around margin below the image. Would love to hear your perspective.

@danielguillan danielguillan force-pushed the danielguillan/add-pillar-image-support branch from 350b80a to 264f604 Compare December 17, 2024 17:44
@danielguillan danielguillan force-pushed the danielguillan/add-pillar-image-support branch from ce4dfc1 to d07ee45 Compare December 18, 2024 14:28
@danielguillan danielguillan merged commit eba0c53 into main Dec 20, 2024
16 of 17 checks passed
@danielguillan danielguillan deleted the danielguillan/add-pillar-image-support branch December 20, 2024 14:54
@primer-css primer-css mentioned this pull request Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature request] Add image support to the Pillar component
3 participants