-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SubdomainNavBar overflow fix #451
SubdomainNavBar overflow fix #451
Conversation
🦋 Changeset detectedLatest commit: e5fdb21 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
🟢 No design token changes found |
🟢 No visual differences foundOur visual comparison tests did not find any differences in the UI. |
ce55f07
to
e488e8a
Compare
6a4976a
to
f1955b5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nsolerieu @natalie-iv - FYI due to space constraints, we're proposing to drop the title at the narrowest viewport 👇
It will reappear again at the next larger breakpoint.
Is this cool with y'all? FYI, we also already have an option to use this pattern without the title, even at desktop, so this is building on top of that precedent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sense, shit it 🚀
I think it makes sense considering space/size but we are loosing an important semantic element which my create a bit of confusion... but I don't have a (great) solution to offer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary
This PR fixes 2 issues:
SubdomainNavBar
on mobile #405)Fixes #405
List of notable changes:
The if the Nav menu is open, the background will no longer be scrollable, but the Nav menu will be.
What should reviewers focus on?
Verify that the SubdomainNavBar is working as intended, and there were no unintended side-effect changes.
Steps to test:
MobileMenuOpenManyItems
in Storybook and verify that it is working as intended.Supporting resources (related issues, external links, etc):
Contributor checklist:
Reviewer checklist:
Screenshots: