-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Site refactor] Documentation update #439
Conversation
|
🟢 No design token changes found |
|
|
||
![](https://github.com/primer/brand/assets/912236/78a81f0e-55d5-4db5-8a8b-3184394fac51) | ||
|
||
#### Profile cards |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I rather adjust the styles in Doctocat than bumping each upper level heading, as this section deserves 3 levels at least 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, left some feedback / suggestions but pre-emptively approving to help move it along 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a couple of comments out of curiosity but everything looks good.
Summary
This PR updates image examples in the design guidelines regarding the latest Typographic and border radius scale changes. This affects a list of component like Hero, River, CTABanners, etc.
This is part of the documentation update issue: https://github.com/github/primer/issues/2620
List of notable changes:
Label
image examplesFAQ
image examplesCTABanner
image examplesCTAForm
image examplesGrid
image examples and layoutHeading
image examplesRiver
image examplesWhat should reviewers focus on?
Documentation is updated with latest site refactor designs.
Preview: https://primer-e6cc30237b-26139705.drafts.github.io/components/CTABanner
Supporting resources (related issues, external links, etc):
Contributor checklist:
Reviewer checklist:
Screenshots: