prepare for release #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is broken because I don't know how to fix the move problem at the moment, there is a PR open that could address it but there's also probably a way to go around it which I can't come up with right now |
ivoreis
reviewed
Nov 25, 2024
src/macros/event_with_options.rs
Outdated
| /// Send a custom event as a title and a body | ||
| /// NOTE: Try to minimise variation in tag values (avoid things like timestamps or ids). See note in lib docs! | ||
| #[macro_export] | ||
| macro_rules! event_with_options { |
There was a problem hiding this comment.
WDYT about extending the event! Instead of creating a new one? It could receive the EventOptions as an argument and pass it to $crate::Datadog::event_with_options instead of $crate::Datadog::event.
There was a problem hiding this comment.
I was debating the two options, I think it may make sense to expose just one macro
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.