Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CHANGELOG and prepare for release #71

Merged
merged 4 commits into from
Aug 22, 2024
Merged

Update CHANGELOG and prepare for release #71

merged 4 commits into from
Aug 22, 2024

Conversation

cpiemontese
Copy link
Contributor

No description provided.

@cpiemontese cpiemontese requested a review from 23Skidoo August 21, 2024 13:33
@cpiemontese cpiemontese requested a review from a team as a code owner August 21, 2024 13:33
23Skidoo
23Skidoo previously approved these changes Aug 21, 2024
Copy link
Contributor

@23Skidoo 23Skidoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I also checked that accielle builds against this branch.

CHANGELOG.md Outdated

### Changed

- update itertools to 0.13.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also positional_derive's dependency on syn seems to have been bumped to v2.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I felt there had been other changes, thanks!

@cpiemontese
Copy link
Contributor Author

@23Skidoo we know next to nothing about this library, do you think it would make sense for your team or domain to own it...?

Copy link
Contributor

@23Skidoo 23Skidoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


### Changed

- update criterion to 0.5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

criterion is a dev dependency, but ok

@23Skidoo
Copy link
Contributor

@cpiemontese I'll raise it with my team.

@cpiemontese cpiemontese merged commit c225723 into master Aug 22, 2024
7 checks passed
@cpiemontese cpiemontese deleted the release branch August 22, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants