Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PLATFORM-1689]: Attach to subscription publish events #148

Merged
merged 14 commits into from
Apr 18, 2024
Merged

[PLATFORM-1689]: Attach to subscription publish events #148

merged 14 commits into from
Apr 18, 2024

Conversation

cpiemontese
Copy link
Contributor

@cpiemontese cpiemontese commented Apr 17, 2024 •
edited
Loading

@cpiemontese cpiemontese requested a review from a team as a code owner April 17, 2024 12:27
@cpiemontese
Copy link
Contributor Author

This will close #145

@cpiemontese cpiemontese changed the title [PLATFORM-1673]: Create Lever-Personio integration tool for HR [PLATFORM-1689]: Attach to subscription publish events Apr 17, 2024
MaeIsBad
MaeIsBad previously approved these changes Apr 17, 2024
View reviewed changes
Copy link
Member

@MaeIsBad MaeIsBad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually should we keep this behind a feature flag?

@cpiemontese cpiemontese requested a review from MaeIsBad April 18, 2024 06:59
@cpiemontese
Copy link
Contributor Author

cpiemontese commented Apr 18, 2024 •
edited
Loading

@MaeIsBad I made it optional behind a flag and refactored the code to make that more testable

MaeIsBad
MaeIsBad approved these changes Apr 18, 2024
View reviewed changes
Copy link
Member

@MaeIsBad MaeIsBad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@cpiemontese cpiemontese merged commit 91a1f79 into master Apr 18, 2024
5 checks passed
@cpiemontese cpiemontese deleted the fanatics-live/master branch April 18, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaeIsBad MaeIsBad MaeIsBad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cpiemontese @MaeIsBad @aej