Expose reqwest features for rustls #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nemosupremo thank you for this PR. Do you need a new release of jwks_client? |
cottinisimone
approved these changes
Feb 12, 2024
|
@cottinisimone any chance to see a release with this feature in? |
|
We also ran into this issue and could make good use of a new release! |
|
That was fast, thanks :) |
|
Yeah, I just saw this and I created a new release 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default reqwest uses the feature
default-tls, which on linux loadsrust-openssl. This requires having the appropriate openssl packages installed as well as makes cross compiling a bit more difficult. Most packages expose a feature to allow the user to choose which ssl library gets use. Without this feature, openssl gets pulled into your crate, even if you have other reqwest dependencies using rustls.This PR exposes those features.