Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PLATFORM-1798]: Maintained libraries cleanup #34

Merged
merged 3 commits into from
Jul 25, 2024
Merged

[PLATFORM-1798]: Maintained libraries cleanup #34

merged 3 commits into from
Jul 25, 2024

Conversation

cpiemontese
Copy link
Contributor

@cpiemontese cpiemontese marked this pull request as ready for review July 24, 2024 10:04
@cpiemontese cpiemontese requested a review from a team as a code owner July 24, 2024 10:04
chess4ever
chess4ever previously approved these changes Jul 24, 2024
View reviewed changes
cottinisimone
cottinisimone previously approved these changes Jul 24, 2024
View reviewed changes
@cottinisimone
Copy link
Contributor

cottinisimone commented Jul 24, 2024 •
edited
Loading

Remember that to complete the handover we need to:

  • move ownership in umami to grant claims maintain permissions
  • move ownership in backstage (create here the catalog-info file)
  • move ownership in notion Github Asset Registry page (i remember it's done automatically, maybe from umami, but it's better to check it).

@cpiemontese cpiemontese dismissed stale reviews from cottinisimone and chess4ever via 2d8b414 July 24, 2024 10:19
@cpiemontese
Copy link
Contributor Author

I took the liberty of adding a catalog info for Backstage and assigned the project to team-claims which should represent the whole domain

@cpiemontese cpiemontese merged commit a907c69 into master Jul 25, 2024
5 checks passed
@cpiemontese cpiemontese deleted the PLATFORM-1798/task/maintained-libraries-cleanup branch July 25, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chess4ever chess4ever chess4ever approved these changes

@cottinisimone cottinisimone Awaiting requested review from cottinisimone

@MaeIsBad MaeIsBad Awaiting requested review from MaeIsBad

@samuel-sanchez-prima samuel-sanchez-prima Awaiting requested review from samuel-sanchez-prima

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cpiemontese @cottinisimone @chess4ever