Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: defaultLayerHeader chevron rotation #604

Merged
merged 2 commits into from
Feb 8, 2024
Merged

Conversation

Hahlh
Copy link
Contributor

@Hahlh Hahlh commented Jan 20, 2024

The current animation of the chevron misplaces it in the layout and looks somewhat broken.

This PR addresses this by centering the svg in the link container and setting the transform-origin to its direct center.

Before:

chevron_rotation_before-2024-01-20_14.32.43.mp4

After:

chevron_rotation_after-2024-01-20_14.42.59.mp4

@Hahlh Hahlh requested a review from prevwong as a code owner January 20, 2024 13:45
Copy link

changeset-bot bot commented Jan 20, 2024

🦋 Changeset detected

Latest commit: e11fa33

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@craftjs/layers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jan 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
craftjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 8, 2024 6:44am

@prevwong prevwong changed the title Improve defaultLayerHeader chevron rotation fix: defaultLayerHeader chevron rotation Feb 8, 2024
Copy link
Owner

@prevwong prevwong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! ❤️

@prevwong prevwong merged commit 7d091ab into prevwong:main Feb 8, 2024
3 checks passed
@github-actions github-actions bot mentioned this pull request Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants