Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: drag shadow on Safari #587

Merged
merged 2 commits into from
Dec 26, 2023
Merged

fix: drag shadow on Safari #587

merged 2 commits into from
Dec 26, 2023

Conversation

Accir
Copy link
Contributor

@Accir Accir commented Dec 1, 2023

Related to: #519

Fixes Safari drag shadow bug, where it is not visible when dragging. By changing display property to absolute, background is required as it will otherwise be transparent. By default I set the background to white. If any user wants to modify drag shadow css, I added additional classes drag-shadow and drag-shadow-container.

@Accir Accir requested a review from prevwong as a code owner December 1, 2023 11:08
Copy link

changeset-bot bot commented Dec 1, 2023

🦋 Changeset detected

Latest commit: 7b06159

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@craftjs/core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Dec 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
craftjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 1, 2023 0:11am

@Accir
Copy link
Contributor Author

Accir commented Dec 1, 2023

As I test this further I realised that background is not necessary as it is intended functionality that drag shadows have no background if the dragged element has no background. So only the position change should be sufficient to fix this bug.

Copy link
Owner

@prevwong prevwong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! ❤️

@prevwong prevwong merged commit e4bc34c into prevwong:main Dec 26, 2023
2 checks passed
@github-actions github-actions bot mentioned this pull request Dec 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants