Remove skip prefix from AI move scores #1163
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possible naming improvement in the
engine/battle/ai/scoring.asm
file. I'm making some refactors to this file for my own game where the AI is a bit stronger and noticed these subroutines that useskip
as a prefix. I thought the wordskip
was misleading since in all of the routines they are not skipping that action they are prefixing; in fact, they are all attempting to do the action that their name suggests they are skipping.I know that the name is intended to show that they are skipping the discouragement or encouragement from the regular flow of the routine that calls it, but I still found the word
skip
misleading.I considered also switching the
skip
formaybe
but I don't think that works as it looks likemaybe
is used as a convention when some chance is involved withAI_50_50
or one of those similar routines is used. I felt just usingdiscourage
orencourage
kept the naming more consistent within the file instead of usingskip
ormaybe
for these examples.If people disagree with my take on this, no worries! 👍