Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove skip prefix from AI move scores #1163

Merged
merged 4 commits into from
Dec 29, 2024

Conversation

jordanmoore753
Copy link
Contributor

Possible naming improvement in the engine/battle/ai/scoring.asm file. I'm making some refactors to this file for my own game where the AI is a bit stronger and noticed these subroutines that use skip as a prefix. I thought the word skip was misleading since in all of the routines they are not skipping that action they are prefixing; in fact, they are all attempting to do the action that their name suggests they are skipping.

I know that the name is intended to show that they are skipping the discouragement or encouragement from the regular flow of the routine that calls it, but I still found the word skip misleading.

I considered also switching the skip for maybe but I don't think that works as it looks like maybe is used as a convention when some chance is involved with AI_50_50 or one of those similar routines is used. I felt just using discourage or encourage kept the naming more consistent within the file instead of using skip or maybe for these examples.

If people disagree with my take on this, no worries! 👍

@jordanmoore753 jordanmoore753 marked this pull request as ready for review December 28, 2024 16:06
@Rangi42 Rangi42 merged commit 86a87a3 into pret:master Dec 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants