Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] show missing operators in stage tab #24171

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

LeonidChistov
Copy link

@LeonidChistov LeonidChistov commented Nov 29, 2024

Description

Pull Request is a fix for issue #24054.

Original problem is that Presto UI Stage Performance tab does not show operators which refer to plan nodes which were created on worker side during plan rewriting and are not present in original plan.

Proposed fix changes Presto UI logic to use only operatorSummaries section for pipelines rendering and avoid referring to query plan which seems to be obsolete for pipelines reconstruction.

Motivation and Context

described above

Impact

Impacts (improves) ability of query performance analysis by showing operators previously not rendered in UI.

Test Plan

Manual tests on several TPCH queries and comparing stage tab content.

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== NO RELEASE NOTE ==

Copy link

CLA Missing ID CLA Not Signed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant