Add new -engine option
#530
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamluc
force-pushed
the
add-engine-option
branch
from
8fb3d68
to
96610ac
Compare
|
Dropped a comment in #520 (comment) It appears different folks want different engine implementations, so this warrants a bit of a discussion. |
Thanks @mfridman, I replied to the comment in the other PR. |
|
Dropped a comment in another PR, but it attempts to accomplish the same thing. Would love your feedback if supplying your own small implementation would suite your needs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I use goose on a ClickHouse cluster.
Unfortunately, the migrations table is created with the
MergeTreeengine which is perfect for a single node instance, but causes issue on a replicated clusted which should use theReplicatedMergeTreeengine.This PR adds a new
-engineoption to override the engine. The default value of the option is empty, as it depends of the dialect.Note: I implemented the feature only for ClickHouse, but I guess it could be useful for other databases like MySQL