Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show file lines #1384

Merged
merged 7 commits into from
Nov 15, 2023
Merged

Show file lines #1384

merged 7 commits into from
Nov 15, 2023

Conversation

rzvxa
Copy link
Member

@rzvxa rzvxa commented Oct 25, 2023

Description of Changes

The original author of this PR is @hsnks100 on #1328, I've just added some documentation and made dynamic binding instead of using just a setting variable.
This PR will get merged with a co-author tag to give credit to the author of the initial PR.


New Version Info

Adds a new option and binding for toggling line numbers for files.

@rzvxa rzvxa requested a review from alerque October 25, 2023 22:13
@rzvxa
Copy link
Member Author

rzvxa commented Nov 14, 2023

@alerque Hi, By any chance is it possible for you to review this PR? I think it's a sweet addition to the NERDTree, Line counting uses the wc command whenever possible. If not it will fall back to the FIND command on Windows otherwise it will count up to the first 20000 lines using Vimscript implementation.

alerque
alerque previously approved these changes Nov 15, 2023
I forgot to remove old change log entry added by the original author of this PR
@rzvxa rzvxa merged commit 0cb04e9 into preservim:master Nov 15, 2023
1 check passed
@isaiah
Copy link

isaiah commented Jan 2, 2024

The keybinding override the navigation shortcut to move the cursor to the bottom, which is very important, is it possible to disable the keybinding?
https://github.com/preservim/nerdtree/pull/1384/files#diff-19392c14a742ab8948180b2b6a82e99321d1722b618ba00d3ac5dc805e8b0702R134

@rzvxa
Copy link
Member Author

rzvxa commented Jan 2, 2024

@isaiah Yeah, you should be able to rebind this key to anything you desire using g:NERDTreeMapToggleFileLines.
If you have any non-clashing alternative key bind please create an issue, nothing is stopping us from remapping this default key bind to something more reliable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants