Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update actions in GitHub Actions workflows #382

Merged
merged 4 commits into from
Sep 24, 2024
Merged

Update actions in GitHub Actions workflows #382

merged 4 commits into from
Sep 24, 2024

Conversation

MGaetan89
Copy link
Contributor

This PR updates the various actions used in the existing GitHub Actions workflows:

  • ubuntu-18.04ubuntu-latest
  • actions/checkout@v1v4
  • actions/checkout@v2v4
  • actions/setup-java@v1v4
  • eskatos/gradle-command-action@v1gradle/actions/setup-gradle@v4
  • actions/upload-artifact@v1v4

This PR updates the various actions used in the existing GitHub Actions workflows.
- `ubuntu-18.04` → `ubuntu-latest`
- `actions/checkout@v1` → `v4`
- `actions/checkout@v2` → `v4`
- `actions/setup-java@v1` → `v4`
- `eskatos/gradle-command-action@v1` → `gradle/actions/setup-gradle@v4`
- `actions/upload-artifact@v1` → `v4`
@MGaetan89 MGaetan89 mentioned this pull request Sep 24, 2024
@MGaetan89
Copy link
Contributor Author

The Gradle Wrapper jar seemed to not match the Gradle version. So I've ran ./gradlew wrapper --gradle-version=8.2 to redownload it and pushed the changes in 5b726e6

@MGaetan89
Copy link
Contributor Author

app/build.gradle needs access to the Git tags:

def getVersionName = { ->
def stdout = new ByteArrayOutputStream()
exec {
commandLine 'git', 'describe', '--tags', '--abbrev=0'
standardOutput = stdout
}
return stdout.toString().trim()
}

So I've enabled fetching the Git tags in unit-tests.yml in 6d79dbe

@premnirmal
Copy link
Owner

app/build.gradle needs access to the Git tags:

def getVersionName = { ->
def stdout = new ByteArrayOutputStream()
exec {
commandLine 'git', 'describe', '--tags', '--abbrev=0'
standardOutput = stdout
}
return stdout.toString().trim()
}

So I've enabled fetching the Git tags in unit-tests.yml in 6d79dbe

Not sure if the unit test build failure (process 'git' failure) is due to the change in ubuntu version?

@MGaetan89
Copy link
Contributor Author

Ok, fetching the tags is not enough, so I've enabled fetching the Git history in bf9e86a

@MGaetan89
Copy link
Contributor Author

app/build.gradle needs access to the Git tags:

def getVersionName = { ->
def stdout = new ByteArrayOutputStream()
exec {
commandLine 'git', 'describe', '--tags', '--abbrev=0'
standardOutput = stdout
}
return stdout.toString().trim()
}

So I've enabled fetching the Git tags in unit-tests.yml in 6d79dbe

Not sure if the unit test build failure (process 'git' failure) is due to the change in ubuntu version?

I've tried fetching the Git history, like in build.yml. Let's see if that works 🤞🏻

@MGaetan89
Copy link
Contributor Author

The setup looks good now. The failures seem to be directly coming from the tests now.

@premnirmal premnirmal merged commit 4554a58 into premnirmal:master Sep 24, 2024
1 of 2 checks passed
@MGaetan89 MGaetan89 deleted the update_workflows branch September 24, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants