35: watchlist shows OTH values #380
Conversation
| @@ -2,11 +2,11 @@ | |||
| "formatVersion": 1, | |||
| "database": { | |||
| "version": 6, | |||
| "identityHash": "a9411595d733a02f3a0d29b7aba56959", | |||
There was a problem hiding this comment.
Prefer this to be untouched and a new version 7 schema be added to this folder
There was a problem hiding this comment.
Updated. I still need some help with making sure the 6->7 migration runs :)
| app:layout_constraintTop_toBottomOf="@+id/name" /> | ||
|
|
||
| <EditText | ||
| android:id="@+id/othText" |
There was a problem hiding this comment.
The positions layout (item_position.xml) is unchanged. Does it also need these changes or is it ok to not include marked closed text?
There was a problem hiding this comment.
Personally I'd rather see both "At close" and "Market closed" values if that's what you're asking. If you want to remove the titles themselves then sure, but we need to make sure it's clear which values represent what (open/close/at close).
| android:background="@null" | ||
| android:ems="10" | ||
| android:inputType="text" | ||
| android:text="Market Closed:" |
There was a problem hiding this comment.
the text needs to be translated across languages - can you use strings.xml for all the new text fields?
There was a problem hiding this comment.
Updated. Used Google Translate so I don't know if the translations are good enough.
orfins
force-pushed
the
feat/oth-values-in-watchlist
branch
2 times, most recently
from
5378ae5 to
01f5c26
Compare
orfins
force-pushed
the
feat/oth-values-in-watchlist
branch
from
01f5c26 to
b16123d
Compare
This PR adds OTH values to the watchlist tab only (will not be seen in the widget)
*This is my first time developing an app, so please let me know of any changes I should make. For example, I do need some help with db migrations - they don't seem to run on startup.
This is what the Watchlist tab looks like with the changes: