fix colour resources crash on android 11

premnirmal · Jul 24, 2022 · b8fef3f · b8fef3f
1 parent 154f9f6
commit b8fef3f
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 4 deletions.
diff --git a/app/src/main/kotlin/com/github/premnirmal/ticker/portfolio/PortfolioVH.kt b/app/src/main/kotlin/com/github/premnirmal/ticker/portfolio/PortfolioVH.kt
@@ -23,10 +23,18 @@ abstract class PortfolioVH(itemView: View) : RecyclerView.ViewHolder(itemView),
   protected val positiveColor: Int = ContextCompat.getColor(itemView.context, R.color.positive_green)
   protected val negativeColor: Int = ContextCompat.getColor(itemView.context, R.color.negative_red)
   protected val neutralColor: Int by lazy {
-    val typedValue = TypedValue()
-    val theme: Theme = itemView.context.theme
-    theme.resolveAttribute(com.google.android.material.R.attr.colorOnSurfaceVariant, typedValue, true)
-    ContextCompat.getColor(itemView.context, typedValue.data)
+    try {
+      val typedValue = TypedValue()
+      val theme: Theme = itemView.context.theme
+      theme.resolveAttribute(
+        com.google.android.material.R.attr.colorOnSurfaceVariant,
+        typedValue,
+        true
+      )
+      ContextCompat.getColor(itemView.context, typedValue.data)
+    } catch (e: Exception) {
+      ContextCompat.getColor(itemView.context, R.color.text_2)
+    }
   }
 
   @Throws(Exception::class) protected abstract fun updateView(quote: Quote, color: Int)

diff --git a/app/src/main/res/values-night/color_palette.xml b/app/src/main/res/values-night/color_palette.xml
@@ -11,4 +11,5 @@
   <color name="negative_red">#ff6666</color>
   <color name="positive_green">#ccff66</color>
   <color name="positive_green_dark">#009900</color>
+  <color name="text_2">#fff3f3f3</color>
 </resources>
diff --git a/app/src/main/res/values/color_palette.xml b/app/src/main/res/values/color_palette.xml
@@ -23,5 +23,6 @@
   <color name="negative_red">#e55b5b</color>
   <color name="positive_green">#009900</color>
   <color name="positive_green_dark">#006b00</color>
+  <color name="text_2">#6e6e6e</color>
 
 </resources>