Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: supress git clone output and long test names #222

Merged
merged 1 commit into from
Feb 15, 2024
Merged

fix: supress git clone output and long test names #222

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions crates/rattler_installs_packages/src/artifacts/sdist.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -656,7 +656,7 @@ mod tests {
}

#[tokio::test(flavor = "multi_thread")]
pub async fn build_rich_sdist_but_without_metadata_in_path_as_source_dependency() {
pub async fn sdist_without_name() {
let path = Path::new(env!("CARGO_MANIFEST_DIR"))
.join("../../test-data/sdists/rich_without_metadata_in_path.tar.gz");

Expand Down Expand Up @@ -1295,7 +1295,7 @@ mod tests {
}

#[tokio::test(flavor = "multi_thread")]
pub async fn test_zip_timestamps_before_1980_error() {
pub async fn test_zip_timestamps_1980() {
let url = Url::parse("https://files.pythonhosted.org/packages/c0/3f/d7af728f075fb08564c5949a9c95e44352e23dee646869fa104a3b2060a3/tomli-2.0.1.tar.gz").unwrap();

let package_db = get_package_db();
Expand Down
0 ...etadata_in_path_as_source_dependency.snap → ...ts__sdist__tests__sdist_without_name.snap
View file
Open in desktop
File renamed without changes.
0 ...ts__zip_timestamps_before_1980_error.snap → ...s__sdist__tests__zip_timestamps_1980.snap
View file
Open in desktop
File renamed without changes.
6 changes: 0 additions & 6 deletions crates/rattler_installs_packages/src/index/git_interop.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ use std::collections::HashMap;
use std::fmt;
use std::{
fmt::{Display, Formatter},
io::IsTerminal,
path::PathBuf,
process::Command,
str::FromStr,
Expand Down Expand Up @@ -221,11 +220,6 @@ fn git_command(sub_cmd: &str) -> Command {
let mut command = Command::new("git");
command.arg(sub_cmd);

if std::io::stdin().is_terminal() {
command.stdout(std::process::Stdio::inherit());
command.stderr(std::process::Stdio::inherit());
command.arg("--progress");
}
command
}

Expand Down