feat: add support for py3.8 and downgrade some of the types #39
Conversation
pixi.toml
Outdated
| ruff = ">=0.5.2,<0.6" | ||
| pyyaml = ">=6.0.1,<7" | ||
| jsonschema = ">=4.23.0,<5" | ||
| pytest = ">=8.3.1,<9" | ||
|
|
||
| [tasks] | ||
| generate = "python model.py > schema.json" | ||
| generate = "python conda_recipe_v2_schema/model.py > new_schema.json" |
|
Good work, definitely uglier :) |
there was a possibility to use https://pypi.org/project/eval-type-backport/ , so we could keep the |
| @@ -8,14 +8,13 @@ platforms = ["win-64", "linux-64", "osx-64", "osx-arm64"] | |||
| conda-recipe-v2-schema = { path = ".", editable = true } | |||
|
|
|||
| [dependencies] | |||
| pydantic = ">=2.8.2,<3" | |||
There was a problem hiding this comment.
as it is a pure python wheel that is published, I thought that it would be better if we keep using PyPI dependencies only when running tests and not get the conda's
There was a problem hiding this comment.
That is not true :)
Actually we only publish it on conda forge and not on pypi.
There was a problem hiding this comment.
ah, my mistake about stating that we publish pypi wheels , but it's still using sdist in recipe https://github.com/conda-forge/staged-recipes/pull/27080/files#diff-d508595b117e4a8f1f989ca80878ab9b832929b637603eb8f742e7d1fe69417fR9
which will be installed by pip https://github.com/conda-forge/staged-recipes/pull/27080/files#diff-d508595b117e4a8f1f989ca80878ab9b832929b637603eb8f742e7d1fe69417fR14
There was a problem hiding this comment.
Yes?
But the dependencies still come from conda-forge?
There was a problem hiding this comment.
sorry, but I don't get the point here of keeping both pydantic in pyproject.toml and pixi.toml ( by pixi having first-class support of pypi dependencies )
There was a problem hiding this comment.
If we would drop it from pyproject.toml, we couldn't publish it to pypi if we wanted to.
Until we have a way in pixi to automatically install dependencies declared in pyproject.toml from conda, duplication is the best way as far as I can tell.
There was a problem hiding this comment.
why in this case to not keep it only in pyproject.toml, and use pydantic and any other dependencies from pypi ( which pixi does provides for us and test with them) - this unlock the possibility to publish recipe-format as wheel on pypi.
we still need to duplicate pydantic in conda-forge recipe.yaml, so we have 3 places where we duplicate it ( instead of 2 )
|
I also prefer having the conda dependency in there, but also wont block the PR. |
No description provided.