fix: filter cache run_exports with the right ignores #989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's getting closer, but now filtering the run export from the cache in the output doesn't work anymore. |
wolfv
force-pushed
the
fix-run-exports-filter
branch
from
309f846 to
95c35a5
Compare
wolfv
force-pushed
the
fix-run-exports-filter
branch
from
22e94e0 to
63ca0c0
Compare
wolfv
changed the title
wolfv
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is an attempt to fix #977
I think part of the issue was (at least!) that we didn't use the right "ignore_run_exports" (ie. not the one from the cache.
My quick test showed that it still doesn't fix the issue, so will have to dig a little bit more tomorrow. But should be fixed swiftly!