fix: stricter input parsing and more lenient parsing of run exports from other packages #1271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
wolfv
changed the title
|
Can you also make a Pr in rattler? Because now the behavior in rattler-build deviates from rattler itself. |
|
Already done! |
|
Jep just noticed conda/rattler#989 Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently parse
python 3aspython ==3which is a deviation from conda-build (which has some complicated logic to add stars sometimes).With this PR we simplify the logic and ask the user to provide operators, such as
>=3,3.*,==3etc.At the same time we were parsing run exports from other packages in "strict" mode. This did break for some packages (such as
libabseilwhich has a run export in the form oflibabseil =*=*cpp17that doesn't parse in strict mode).