Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add configurable PIXI_HOME #627

Merged
merged 7 commits into from
Jan 10, 2024

Conversation

chawyehsu
Copy link
Contributor

Address #619 , probably also #541

command

# Unix
export PIXI_HOME=/your/custom/pixi/home
# Windows
$env:PIXI_HOME="D:\dev\pixi"
pixi global install <package>

Signed-off-by: Chawye Hsu <[email protected]>
Copy link
Contributor

@ruben-arts ruben-arts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks this work looks good.

Could you align the install scripts to use the same PIXI_HOME variable. I see we use PIXI_DIR which would be better to change to PIXI_HOME?
And could you mention this in the configuration documentation that its possible to set this variable.

@chawyehsu
Copy link
Contributor Author

will do.

@chawyehsu
Copy link
Contributor Author

Ready for reviews.

Copy link
Contributor

@ruben-arts ruben-arts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the addition! Looks good to me!

@wolfv wolfv merged commit 4f89ac6 into prefix-dev:main Jan 10, 2024
11 checks passed
@chawyehsu chawyehsu deleted the feature/configurable-pixi-home branch October 11, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants