Split pypi and conda solve steps #601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Moved files 2. Clippy fixed some small issues
baszalmstra
pushed a commit
that referenced
this pull request
Jan 2, 2024
Refactored the pypi environment installation code into it's own module. #601 depends on this.
baszalmstra
reviewed
Jan 2, 2024
ruben-arts
changed the title
ruben-arts
changed the title
|
Im currently looking at the test failures and merge conflict. |
ruben-arts
reviewed
Jan 4, 2024
Co-authored-by: Ruben Arts <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did a large refactor that does two main things:
get_up_to_date_prefixfunction so it accepts ano_installflag. This way we can actually use it everywhere instead of duplicating a lot of code.Later on we will need to actually use the interpreter in the sdist resolution step.
PR depends on #589, need to merge that first.