feat: add new commands for pixi project {version|channel|platform|description}
#579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hadim
commented
Dec 18, 2023
hadim
commented
Dec 18, 2023
hadim
commented
Dec 18, 2023
hadim
commented
Dec 18, 2023
hadim
commented
Dec 18, 2023
ruben-arts
requested changes
Dec 19, 2023
There was a problem hiding this comment.
Awesome work @hadim!
I left some comments with some requests for change. Please note the eprintln changes.
I would skip the version bump stuff in this pr and clean it up then we can merge it soon!
Wasn't expecting this to be fixed so soon!
This was referenced Dec 19, 2023
… for better consistency.
Co-authored-by: Ruben Arts <[email protected]>
Co-authored-by: Ruben Arts <[email protected]>
Co-authored-by: Ruben Arts <[email protected]>
Co-authored-by: Ruben Arts <[email protected]>
Co-authored-by: Ruben Arts <[email protected]>
Co-authored-by: Ruben Arts <[email protected]>
Co-authored-by: Ruben Arts <[email protected]>
…dd|remove}_channels
|
@ruben-arts LGTM. Please let me know about the "CLI" tests in |
ruben-arts
requested changes
Dec 20, 2023
hadim
commented
Dec 20, 2023
ruben-arts
approved these changes
Dec 20, 2023
|
@ruben-arts Thanks for the help and the review! All good on my side. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A first proposal for #575
The idea is to add a few new
pixi projectcommands:pixi project description setpixi project description getpixi project channel listpixi project channel removepixi project platform listpixi project platform removepixi project platform addpixi project version getpixi project version setpixi project version {major,minor,patch}: I did a first pass, but I feel the logic should live on rattler, no?Tests are missing.
See also a few comments/questions below.