Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow configuring pypi insecure host #2521

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

zen-xu
Copy link
Contributor

@zen-xu zen-xu commented Nov 20, 2024

close #1982

@zen-xu zen-xu changed the title feat: allow configuring insecure host feat: allow configuring pypi insecure host Nov 20, 2024
@ruben-arts
Copy link
Contributor

This looks good to me, @tdejager could you review this?

@tdejager
Copy link
Contributor

tdejager commented Nov 21, 2024

Thanks @zen-xu for the PR! The Implementation looks fine, the question for me would be if we want uv_configuration as a dependency because then we can never publish this specific crate, otherwise we need to define the type and conversion ourselves. Personally, I'd be for that.
cc @ruben-arts @baszalmstra

crates/pixi_config/Cargo.toml Outdated Show resolved Hide resolved
@zen-xu zen-xu requested a review from tdejager November 28, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid peer certificate with --tls-no-verify
3 participants