Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perpendicular flap (IGA solid participant G+Smo) #603

Draft
wants to merge 16 commits into
base: develop
Choose a base branch
from

Conversation

Crazy-Rich-Meghan
Copy link

Perpendicular Flap with G+Smo (IsoGeometric Analysis) and OpenFOAM

NOTE: Stress instead of Force.

This PR is still a draft, because the G+Smo adapter's documentation is still ongoing.

I have added a README.md file to guide users on running the tutorial with G+Smo. It includes detailed instructions for setup and execution.

@fsimonis fsimonis requested a review from uekerman December 9, 2024 12:50
Copy link
Member

@uekerman uekerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these great contributions!
I did not yet try it out, but wanted to give some initial tips already.

Guidelines worth checking out:

perpendicular-flap-stress/README.md Outdated Show resolved Hide resolved
perpendicular-flap-stress/README.md Outdated Show resolved Hide resolved
### Runnning the G+Smo Tutorial
Open two terminals and run:
```
cd solid-gismo-elasticity
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
cd solid-gismo-elasticity
cd solid-gismo

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @uekerman,

We have another variant of this benchmark uses Kirichhoff-Love shell elememt and will be called solid-gismo-shell. While the KL shell variant has been verified for both accuracy and convergence, the implementation is currently hard-coded and needs to be generalized to support other examples.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we eventually keep both in the same folder and pick them within the run.sh script?

perpendicular-flap-stress/README.md Outdated Show resolved Hide resolved
perpendicular-flap-stress/README.md Outdated Show resolved Hide resolved
perpendicular-flap-stress/README.md Outdated Show resolved Hide resolved
perpendicular-flap-stress/README.md Outdated Show resolved Hide resolved
perpendicular-flap-stress/README.md Outdated Show resolved Hide resolved
perpendicular-flap-stress/solid-gismo-elasticity/clean.sh Outdated Show resolved Hide resolved
perpendicular-flap-stress/solid-gismo-elasticity/run.sh Outdated Show resolved Hide resolved

```
make solid-gismo-elasticity -j<number of threads to use>
```

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can call make install to install it on the system
CC @uekerman

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will go to the adapter docs later, right?
I would leave this up to the user. "Make it discoverable", for example by installing it to the system.

But the tutorial can assume that the executable is discoverable.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @uekerman, we opened a separate PR for the adapter docs: precice/precice.github.io#482

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants