Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax FEniCS requirements. #590

Merged
merged 2 commits into from
Nov 14, 2024

Conversation

BenjaminRodenberg
Copy link
Member

@BenjaminRodenberg BenjaminRodenberg commented Nov 14, 2024

The required FEniCS versions in the requirements.txt files were too strict. I relaxed the requirements now to allow for updates.

Closes #589

Checklist:

  • I added a summary of any user-facing changes (compared to the last release) in the changelog-entries/<PRnumber>.md.
  • I will remember to squash-and-merge, providing a useful summary of the changes of this PR.

@BenjaminRodenberg
Copy link
Member Author

@MakisH can you check if this works with the systemtests? If everything works: Feel free to just go ahead and merge.

Copy link
Member

@MakisH MakisH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the quick fix! 🤗

@MakisH MakisH merged commit 9c0d23c into precice:develop Nov 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FEniCS cases requirements.txt: fenics-dolfin not found
2 participants