-
-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v202211.1 #558
base: master
Are you sure you want to change the base?
Release v202211.1 #558
Conversation
@@ -75,7 +75,7 @@ def determine_gradient(V_g, u, flux): | |||
# Error is bounded by coupling accuracy. In theory we can obtain the analytical solution. | |||
error_tol = 10 ** -6 | |||
alpha = 3 # parameter alpha | |||
beta = 1.3 # parameter beta | |||
beta = 1.2 # parameter beta |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need to change a model parameter in a bugfix release? I know that this was changed in the v202404, but wouldn't this confuse users if v202211.0 and v202211.1 have different values?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The parameter was not consistent with literature. So I would consider it as a bug that we can also fix in a bugfix release. But let's continue this discussion in #378.
Additionally, if we want to make sure Looks to me like a rabbit hole: Therefore, I would leave things as they are. The user would have to do the |
See precice/precice.github.io#414 for the motivation for this bugfix release.
I'm creating this branch and PR to start collecting relevant changes. Note that it is still unclear if and how we actually would merge these changes into
master
.ToDos:
requirements.txt
and venvs for Python tutorials #563Checklist:
changelog-entries/<PRnumber>.md
.