Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require setuptools>=61 #207

Merged

Conversation

BenjaminRodenberg
Copy link
Member

@BenjaminRodenberg BenjaminRodenberg commented Jul 9, 2024

Requiring setuptools>=61 allows us to remove a noisy warning that always shows up when building with spack. It also allows us to simplify the setup.py. Setuptools>=61 guarantees that pyproject.toml is used.

Copy link
Member

@fsimonis fsimonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good way forward. Now pyproject.toml 😄

@BenjaminRodenberg
Copy link
Member Author

Good way forward. Now pyproject.toml 😄

I've put this into #208

@BenjaminRodenberg BenjaminRodenberg merged commit 561b215 into precice:develop Jul 9, 2024
10 checks passed
BenjaminRodenberg added a commit that referenced this pull request Aug 27, 2024
* Require setuptools>=61. Will ensure use of pyproject.toml.
* Simplify setup.py w.r.t noisy warning (always shown when building with spack).
BenjaminRodenberg added a commit that referenced this pull request Aug 27, 2024
* Require setuptools>=61. Will ensure use of pyproject.toml.
* Simplify setup.py w.r.t noisy warning (always shown when building with spack).
BenjaminRodenberg added a commit that referenced this pull request Dec 5, 2024
* Lint markdown files and update files correspondingly. (#180)
* Add Cython as dependency required during installation (#177)
* Adapt Docker workflow according to new system tests design (#186)
  - modify args to fit to systemtest
  - make the manual triggering more useful
  - move latest tag to last master
* bash string handling... Fun stuff
* sprinkle in some "
* adding some "debug" ouptut
* Update .github/workflows/build-docker.yml
* Require setuptools>=61 (#207)
* Restrict to numpy < 2 and setuptools < 72 for better compatibiltiy with CI pipeline (#213)
* Simplify setup.py w.r.t noisy warning (always shown when building with spack).
* Use Ubuntu 24.04.
* Explicitly specify docker image tags in CI.
* use spack base image precice/ci-spack-pyprecice-deps-2404:2.5.1.0
* use precice base image precice/precice:2.5.1
* Add entry in changelog.
* Fix spack workflow for 2.5.1.0.
* Add branch for release candidate of 2.5.1.0
* Update build dependencies for release candidate
* Use PyPI token instead of username and password in the package publishing action

---------

Co-authored-by: Ishaan Desai <[email protected]>
Co-authored-by: valentin-seitz <[email protected]>
Co-authored-by: Valentin Seitz <[email protected]>
Co-authored-by: Gerasimos Chourdakis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants