Skip to content

Commit

Permalink
Restrict to numpy < 2 and setuptools < 72 for better compatibiltiy wi…
Browse files Browse the repository at this point in the history
…th CI pipeline (#213)

* Restrict to numpy<2 since we do not support numpy 2 yet.
* Restrict to setuptools < 72 since the "test" command was removed in Setuptools 72. See #214.
  • Loading branch information
BenjaminRodenberg authored Aug 27, 2024
1 parent 45b3ecc commit 75da6d8
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 4 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ All notable changes to this project will be documented in this file.

## latest

* Restrict to numpy < 2 for better compatibility with CI pipeline. https://github.com/precice/python-bindings/pull/213
* Require setuptools < 72 since support for the test command was removed in Setuptools 72. https://github.com/precice/python-bindings/pull/213
* Require setuptools >= 61 to guarantee that pyproject.toml is used https://github.com/precice/python-bindings/pull/207
* Fix CI pipeline for spack https://github.com/precice/python-bindings/pull/206

Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
[build-system]
# PEP 518 - minimum build system requirements
requires = ["setuptools>=61", "wheel", "Cython>=0.29", "packaging", "pip>=19.0.0", "numpy", "mpi4py", "pkgconfig"]
requires = ["setuptools>=61,<72", "wheel", "Cython>=0.29", "packaging", "pip>=19.0.0", "numpy<2", "mpi4py", "pkgconfig"]
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ def initialize_options(self):
author_email='[email protected]',
license='LGPL-3.0',
python_requires='>=3',
install_requires=['numpy', 'mpi4py', 'Cython'],
install_requires=['numpy<2', 'mpi4py', 'Cython'],
# mpi4py is only needed, if preCICE was compiled with MPI
# see https://github.com/precice/python-bindings/issues/8
packages=['precice'],
Expand Down
4 changes: 2 additions & 2 deletions spack/repo/packages/py-pyprecice/package.py
Original file line number Diff line number Diff line change
Expand Up @@ -58,8 +58,8 @@ class PyPyprecice(PythonPackage):
depends_on("precice@" + ver, when="@" + ver)

depends_on("python@3:", type=("build", "link", "run"))
depends_on("py-setuptools@61:", type="build")
depends_on("py-numpy", type=("build", "link", "run"))
depends_on("py-setuptools@61:71", type="build")
depends_on("py-numpy@:1", type=("build", "link", "run"))
depends_on("py-mpi4py", type=("build", "run"))
depends_on("[email protected]:", type="build")
depends_on("py-packaging", type="build")
Expand Down

0 comments on commit 75da6d8

Please sign in to comment.