Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused import of micro simulations #83

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

tjwsch
Copy link
Collaborator

@tjwsch tjwsch commented Mar 12, 2024

This removes an unnecessary import of the MicroSimulation class that was not used. In a personal meeting, we also discussed if one of the logger level sets could be removed but on further investigation, they seem to serve slightly different purposes.

@tjwsch tjwsch requested review from IshaanDesai and removed request for IshaanDesai March 12, 2024 15:21
Copy link
Member

@IshaanDesai IshaanDesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also please remove the other lines that we discussed? Good to do more than one cleanups in one PR.

@tjwsch
Copy link
Collaborator Author

tjwsch commented Mar 14, 2024

After further investigation on the other lines, I found that setting the logger level in the root logger and a handler serves different purposes, thus both setLevel calls are necessary, as I wrote in my first comment. That was the only other cleanup I remember us discussing.

@IshaanDesai IshaanDesai merged commit e0794f3 into develop Mar 14, 2024
10 checks passed
@IshaanDesai IshaanDesai deleted the remove_unnecessary_code branch March 14, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants