Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs in adaptivity computation #80

Merged
merged 3 commits into from
Feb 8, 2024
Merged

Fix bugs in adaptivity computation #80

merged 3 commits into from
Feb 8, 2024

Conversation

IshaanDesai
Copy link
Member

@IshaanDesai IshaanDesai commented Feb 7, 2024

The following bugs are fixed:

  • The step of updating inactive simulations did not take the correct states from the previous step of updating active simulations.
  • If a situation arises that all the simulations are exactly the same in terms of their output, and all of them are active, the global adaptivity implementation fails to compare them and deactivate all but one simulation. This PR adds functionality to handle this scenario. This can typically happen at the start of a simulation.

@IshaanDesai IshaanDesai self-assigned this Feb 7, 2024
@IshaanDesai IshaanDesai added the bug Something isn't working label Feb 7, 2024
@IshaanDesai IshaanDesai changed the title Fix bug in global adaptivity when all simulations are exactly the same and all are active Fix bugs in adaptivity computation Feb 8, 2024
@IshaanDesai IshaanDesai requested a review from Fujikawas February 8, 2024 12:01
@IshaanDesai IshaanDesai merged commit 60755e6 into develop Feb 8, 2024
10 checks passed
@IshaanDesai IshaanDesai deleted the fix-adaptivity branch February 8, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants