Start coupling with all simulation active #72
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rationale for starting with all simulation in an active state is that if the user has provided only micro data to compute the similarity on, in the first step only one simulation will be solved and the Micro Manager will not get the actual micro-scale data to compute the adaptivity from. Therefore it is necessary to solve all the micro simulations in the first step to generate the necessary micro data from which the similarity will be computed. This also results from the fact that we no longer provide the
initialize()
method in the micro simulation API. As there is no initialization which the Micro Manager can call, it cannot know the micro-scale data before computing the first time step. So either we reintroduce the initialize method and initialize all micro simulations, or we solve all of them in the first time step.Note that this problem occurs only when micro data is provided to the adaptivity. If macro data is provided, the adaptivity will be computing correctly.