Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass global IDs to micro simulations to make them unique #66

Merged
merged 12 commits into from
Feb 2, 2024

Conversation

IshaanDesai
Copy link
Member

Uniqueness of micro simulations is critical if the user wants to manipulate the creation in some way, for example, to create a certain number of micro simulations of a particular type. To allow the user to uniquely identify micro simulations, this PR makes the Micro Manager pass the global ID to the user-side MicroSimulation class.

@IshaanDesai IshaanDesai marked this pull request as draft October 13, 2023 20:15
@IshaanDesai
Copy link
Member Author

@Fujikawas @mathiskelm any user-side objections to doing this? Perhaps it also makes tracking the output files easier.

@IshaanDesai IshaanDesai marked this pull request as ready for review January 29, 2024 15:56
@IshaanDesai IshaanDesai added the enhancement Enchance existing functionality label Feb 2, 2024
@IshaanDesai IshaanDesai merged commit 13fe880 into develop Feb 2, 2024
10 checks passed
@IshaanDesai IshaanDesai deleted the unique-micro-sims branch February 2, 2024 11:42
@IshaanDesai IshaanDesai mentioned this pull request Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enchance existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant