Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring adaptivity data handling #135

Merged
merged 6 commits into from
Dec 16, 2024
Merged

Refactoring adaptivity data handling #135

merged 6 commits into from
Dec 16, 2024

Conversation

IshaanDesai
Copy link
Member

@IshaanDesai IshaanDesai commented Dec 12, 2024

This PR refactors code related to handling of adaptivity data. The primary intention is to make the implementation cleaner and easier to understand. A second purpose is to remove if conditions from the solve routines, to aid performance. The motivation for this refactoring also stems from #133 and how logging adaptivity metrics would be easier with the refactored state.

Checklist:

  • I added a summary of the changes (compared to the last release) in the CHANGELOG.md.
  • I will remember to squash-and-merge, providing a useful summary of the changes of this PR.

@IshaanDesai IshaanDesai self-assigned this Dec 12, 2024
@IshaanDesai IshaanDesai marked this pull request as ready for review December 13, 2024 16:49
@IshaanDesai IshaanDesai merged commit 2e2bead into develop Dec 16, 2024
10 checks passed
@IshaanDesai IshaanDesai deleted the refactor branch December 16, 2024 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant