Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add static type hints (with prompts from Mypy) #134

Merged
merged 3 commits into from
Dec 11, 2024
Merged

Add static type hints (with prompts from Mypy) #134

merged 3 commits into from
Dec 11, 2024

Conversation

IshaanDesai
Copy link
Member

@IshaanDesai IshaanDesai commented Dec 10, 2024 •
edited
Loading

This PR adds type hints to variables wherever possible, mainly with static type checking hints from Mypy.

Checklist:

  • I made sure that the CI passed before I ask for a review.
  • I will remember to squash-and-merge, providing a useful summary of the changes of this PR.

@IshaanDesai IshaanDesai self-assigned this Dec 10, 2024
@IshaanDesai IshaanDesai added the enhancement Enchance existing functionality label Dec 10, 2024
@IshaanDesai IshaanDesai marked this pull request as ready for review December 11, 2024 10:20
@IshaanDesai IshaanDesai merged commit bf29add into develop Dec 11, 2024
10 checks passed
@IshaanDesai IshaanDesai deleted the lint-check branch December 11, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@IshaanDesai IshaanDesai

Labels
enhancement Enchance existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@IshaanDesai