Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move micro_dt from coupling parameters to simulation parameters in the configuration #114

Merged
merged 3 commits into from
Jul 9, 2024

Conversation

IshaanDesai
Copy link
Member

@IshaanDesai IshaanDesai commented Jul 2, 2024

The variable to set the micro simulation dt should be a simulation parameter rather than a coupling parameter. This PR changes the configuration and also all configuration files in the examples and tests. This change also needs to be done for the two-scale-heat-conduction tutorial.

Checklist:

  • I made sure that the CI passed before I ask for a review.
  • I added a summary of the changes (compared to the last release) in the CHANGELOG.md.
  • If necessary, I made changes to the documentation and/or added new content.
  • I will remember to squash-and-merge, providing a useful summary of the changes of this PR.

@IshaanDesai IshaanDesai self-assigned this Jul 2, 2024
@IshaanDesai IshaanDesai added the breaking change A change will break backwards compatibilty label Jul 9, 2024
@IshaanDesai IshaanDesai merged commit 29f93aa into develop Jul 9, 2024
10 checks passed
@IshaanDesai IshaanDesai deleted the micro_dt_sim_param branch July 23, 2024 15:52
@IshaanDesai IshaanDesai mentioned this pull request Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change A change will break backwards compatibilty
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant