Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue #1 #2

Merged
merged 1 commit into from
Mar 17, 2017
Merged

fix issue #1 #2

merged 1 commit into from
Mar 17, 2017

Conversation

mauron85
Copy link
Contributor

@mauron85 mauron85 commented Mar 17, 2017

Remarks:
Creating lib/ReactComponentWithPureRenderMixin.js should be enough.
Adding standalone-react-addons-pure-render-mixin into package.json seems to be unnecessary as it is already referenced in preact-compat.

@notpushkin
Copy link
Member

Thanks! This totally makes sense.
Maybe it would be useful to re-export other modules from preact-compat/lib as well?

/cc @developit

@notpushkin notpushkin merged commit 65497b3 into preact-compat:master Mar 17, 2017
@developit
Copy link
Contributor

Yes, definitely. I wonder if there is a way to generate them, or symlink?

@notpushkin
Copy link
Member

Not sure if Node is good with symlinks right now, there were some issues with them in the past. Besides, I'm not sure if there's a reliable way to get the location where the actual preact-compat is installed if, for example, this happens:

node_modules/
  preact-compat/
  a/
    node_modules/
      react/      (preact-compat/react)

(Although not sure if it's even going to happen at all, if a depends on a real React and not on preact-compat/react)

notpushkin added a commit that referenced this pull request Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants