Set up Storybook; create an Icon component as a proof of concept #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessepinho
force-pushed
the
jessepinho/initial-components
branch
from
c32f545 to
e5dfc45
Compare
jessepinho
force-pushed
the
jessepinho/initial-components
branch
from
e5dfc45 to
17b88a2
Compare
jessepinho
commented
Dec 19, 2024
TalDerei
approved these changes
Dec 19, 2024
There was a problem hiding this comment.
great work wrangling storybook support!
As we discussed offline, we should separately set up the necessary CI pipelines to generate preview Storybook URLs for pull requests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR
<Icon />component as a POC