Improve drawable tinting

DrawableCompat has issue with tinting the layer drawables on Android lollipop (21) devices. So, using setColorFilter(color, mode) method for those devices.
pranavpandey · Feb 9, 2018 · c40fe97 · c40fe97
1 parent 520c64a
commit c40fe97
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 21 deletions.
diff --git a/dynamic-utils/src/main/java/com/pranavpandey/android/dynamic/utils/DynamicDrawableUtils.java b/dynamic-utils/src/main/java/com/pranavpandey/android/dynamic/utils/DynamicDrawableUtils.java
@@ -65,14 +65,11 @@ public static void setBackground(@NonNull View view, @Nullable Drawable drawable
             @Nullable Drawable drawable, boolean wrap, @NonNull ColorFilter colorFilter) {
         if (drawable != null) {
             if (wrap) {
-                drawable = DrawableCompat.wrap(drawable.mutate());
+                drawable = drawable.mutate();
             }
 
             drawable.setColorFilter(colorFilter);
-
-            if (!DynamicVersionUtils.isMarshmallow()) {
-                drawable.invalidateSelf();
-            }
+            drawable.invalidateSelf();
         }
 
         return drawable;
@@ -97,20 +94,26 @@ public static void setBackground(@NonNull View view, @Nullable Drawable drawable
             @Nullable Drawable drawable, boolean wrap,
             @ColorInt int color, @Nullable PorterDuff.Mode mode) {
         if (drawable != null) {
-            if (wrap) {
-                drawable = DrawableCompat.wrap(drawable.mutate());
+            if (mode == null) {
+                mode = PorterDuff.Mode.SRC_IN;
             }
 
-            if (mode != null) {
-                DrawableCompat.setTintMode(drawable, mode);
+            // Handle issue with layer drawables.
+            if (DynamicVersionUtils.isLollipop(true)) {
+                if (wrap) {
+                    drawable = drawable.mutate();
+                    drawable.setColorFilter(color, mode);
+                }
             } else {
-                DrawableCompat.setTintMode(drawable, PorterDuff.Mode.SRC_IN);
-            }
-            DrawableCompat.setTint(drawable, color);
+                if (wrap) {
+                    drawable = DrawableCompat.wrap(drawable.mutate());
+                }
 
-            if (!DynamicVersionUtils.isMarshmallow()) {
-                drawable.invalidateSelf();
+                DrawableCompat.setTintMode(drawable, mode);
+                DrawableCompat.setTint(drawable, color);
             }
+
+            drawable.invalidateSelf();
         }
 
         return drawable;

diff --git a/dynamic-utils/src/main/java/com/pranavpandey/android/dynamic/utils/DynamicWindowUtils.java b/dynamic-utils/src/main/java/com/pranavpandey/android/dynamic/utils/DynamicWindowUtils.java
@@ -50,13 +50,8 @@ public class DynamicWindowUtils {
 
         if (windowManager != null) {
             Display display = windowManager.getDefaultDisplay();
-
-            if (DynamicVersionUtils.isHoneycombMR2()) {
-                display.getSize(size);
-            } else {
-                size.x = display.getWidth();
-                size.y = display.getHeight();
-            }
+            size.x = display.getWidth();
+            size.y = display.getHeight();
         }
 
         return size;