feat: Create consensus traits and implement praos vrf #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KtorZ
reviewed
Oct 3, 2024
| } | ||
|
|
||
| #[test] | ||
| fn test_validate_conway_block() { |
There was a problem hiding this comment.
I feel like this is the kind of test that is a good candidate for snapshot testing: https://insta.rs/. We've been using this extensively within Aiken and it's quite enjoyable for capturing regressions and asserting against specific scenarios.
Not saying this should change now, but I might come and set that up eventually :)
There was a problem hiding this comment.
I've implemented snapshot tests. Please re-check.
AndrewWestberg
force-pushed
the
amw/praos_block_vrf_validation
branch
3 times, most recently
from
ac79452 to
f29542d
Compare
AndrewWestberg
force-pushed
the
amw/praos_block_vrf_validation
branch
from
f29542d to
36b4f01
Compare
|
It's been 5 days. I'm merging this. If you have comments, please make them and I'll clean it up in the next PR. I need to move forward with KES work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.