Fix split admittance for transfomer ratio different from 1 #1121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vidaldid-rte
requested review from
geofjamg,
jeandemanged and
SylvestreSakti
Signed-off-by: Didier Vidal <[email protected]>
vidaldid-rte
force-pushed
the
fix_split_admittance_for_any_ratio
branch
from
6c26fe4
to
135c189
Compare
…rrent tap's ratio Signed-off-by: Didier Vidal <[email protected]>
Signed-off-by: Didier Vidal <[email protected]>
vidaldid-rte
changed the title
Signed-off-by: Didier Vidal <[email protected]>
…om/powsybl/powsybl-open-loadflow into fix_split_admittance_for_any_ratio
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Corrects the formula to split addmittance on a transformer with ratio that is not one.
What is the current behavior?
The admittance is divided b two and one part is set on each one.
If the transformer ratio (ratedU2/ratedU1) is not one, this doesn't lead to the same transformer because the lef
What is the new behavior (if this is a feature change)?
Corrects the formula so that each transformer side has the same admittance but the transofmer is not modified.
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
Other information: