Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Psse. Import. NodeBreaker. Improvements #3258

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

marqueslanauja
Copy link
Contributor

@marqueslanauja marqueslanauja commented Jan 2, 2025

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

What kind of change does this PR introduce?

Feature

What is the current behavior?

Only psse substations with a single voltageLevel are supported.

What is the new behavior (if this is a feature change)?
All psse substations are supported.
A psse substation is considered valid if:

  • All the nodes connected by switches (regardless of the switch status) are associated with a single psse bus.
  • Equipment is associated with the correct psse bus.
  • Bus and node control are coherent.

A voltageLevel is defined as nodeBreaker if all psse buses are within the same psse substation.
The IIDM substation id has been extended to include all the psse buses within it. (Sbus1_bus2_..._busN)

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

Signed-off-by: marquesja1 <[email protected]>
Signed-off-by: marquesja1 <[email protected]>
@geofjamg
Copy link
Member

geofjamg commented Jan 7, 2025

@marqueslanauja what is the status of this PR. Still in draft, ready for review ?

Signed-off-by: marquesja1 <[email protected]>
@marqueslanauja marqueslanauja marked this pull request as ready for review January 7, 2025 08:28
@marqueslanauja
Copy link
Contributor Author

@marqueslanauja what is the status of this PR. Still in draft, ready for review ?

Now, it is ready for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants