Add fix to Matpower importer to import some pglib files #3256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
caioluke
reviewed
Dec 20, 2024
matpower/matpower-model/src/main/java/com/powsybl/matpower/model/MatpowerReader.java
Outdated
Show resolved
Hide resolved
olperr1
reviewed
Jan 6, 2025
| gen.setRampThirtyMinutes(generators.getDouble(row, 18)); | ||
| gen.setRampQ(generators.getDouble(row, 19)); | ||
| gen.setApf(generators.getDouble(row, 20)); | ||
| if (generators.getDimensions()[1] > MATPOWER_V1_GENERATORS_COLUMNS) { |
There was a problem hiding this comment.
As discussed together, it would be safer to use the following test here:
if (generators.getDimensions()[1] >= MATPOWER_V2_GENERATORS_COLUMNS)
=>
- if dimension <
MATPOWER_V1_GENERATORS_COLUMNS: error - if dimension in
[ MATPOWER_V1_GENERATORS_COLUMNS ; MATPOWER_V2_GENERATORS_COLUMNS [: considered as V1 format; - if dimension >=
MATPOWER_V2_GENERATORS_COLUMNS: considered as V2 format.
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
olperr1
requested changes
Jan 7, 2025
| gen.setRampThirtyMinutes(generators.getDouble(row, 18)); | ||
| gen.setRampQ(generators.getDouble(row, 19)); | ||
| gen.setApf(generators.getDouble(row, 20)); | ||
| if (generatorColumnsToRead > 9) { |
There was a problem hiding this comment.
Here, the method will throw an exception in case of a generator table in v1 format (method called with MATPOWER_V1_GENERATORS_COLUMNS which equals 10).
But it may be clearer to have this test instead:
Suggested change
| if (generatorColumnsToRead > 9) { | |
| if (generatorColumnsToRead == MATPOWER_V2_GENERATORS_COLUMNS) { |
because it will be easier to relate it to the possible values for generatorColumnsToRead.
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Feature
What is the current behavior?
Some matpower files like pglib_opf_case1354_pegase.m from https://github.com/power-grid-lib/pglib-opf cannot be imported because the generator column count correspond to v1 format and not v2.
What is the new behavior (if this is a feature change)?
We accept to read the file anyway even with missing columns.
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
Other information: