Fix naming conventions, and allow access to const documents

This will be used for auto-backup, which doesn't not need non-const access

Bug: #392

source/app/documentmanager.cpp

@@ -75,15 +75,23 @@ Document &DocumentManager::addDefaultDocument(
     return doc;
 }
 
-Document &DocumentManager::getCurrentDocument()
+Document &
+DocumentManager::getCurrentDocument()
 {
     if (!myCurrentIndex)
         throw std::logic_error("No documents are currently open");
 
     return *myDocumentList.at(*myCurrentIndex);
 }
 
-Document &DocumentManager::getDocument(int i)
+Document &
+DocumentManager::getDocument(int i)
+{
+    return *myDocumentList.at(i);
+}
+
+const Document &
+DocumentManager::getDocument(int i) const
 {
     return *myDocumentList.at(i);
 }
@@ -120,14 +128,15 @@ int DocumentManager::getCurrentDocumentIndex() const
     return *myCurrentIndex;
 }
 
-size_t DocumentManager::getDocumentListSize() const 
+int
+DocumentManager::getNumDocuments() const
 {
-    return myDocumentList.size();
+    return static_cast<int>(myDocumentList.size());
 }
 
 int DocumentManager::findDocument(const Document::PathType &filepath)
 {
-    for (unsigned int i = 0; i < getDocumentListSize(); ++i)
+    for (int i = 0, n = getNumDocuments(); i < n; ++i)
     {
         Document& doc = getDocument(i);
 

source/app/documentmanager.h

@@ -73,15 +73,17 @@ class DocumentManager
     Document &addDefaultDocument(const SettingsManager &settings_manager);
 
     Document &getCurrentDocument();
+
     Document &getDocument(int i);
+    const Document &getDocument(int i) const;
 
     void removeDocument(int index);
 
     bool hasOpenDocuments() const;
     void setCurrentDocumentIndex(int index);
-
     int getCurrentDocumentIndex() const;
-    size_t getDocumentListSize() const;
+
+    int getNumDocuments() const;
 
     /// Returns -1 if the file at filepath is not open, else it returns the index at which the already open file is at
     int findDocument(const Document::PathType &filepath);