Fix bug which prevented barlines from being deleted

The delete key also now works when the caret is on a barline. Previously the barline needed to also be selected first by clicking on it

#493

CHANGELOG.md

@@ -9,9 +9,11 @@ Thanks to the following contributors who worked on this release:
 ### Added
 
 ### Changed
+- The barline under the cursor can now be deleted without requiring it to be selected first 
 
 ### Fixed
 - Fixed AppStream validation issues in `xdg/powertabeditor.metainfo.xml`
+- Fixed a bug which could prevent barlines from being deleted
 
 ## [2.0.20] - 2024-11-03
 

source/app/powertabeditor.cpp

@@ -3874,6 +3874,8 @@ void PowerTabEditor::updateCommands()
         ScoreUtils::findByPosition(staff.getDynamics(), position);
     const bool positions_selected =
         location.hasSelection() && !location.getSelectedPositions().empty();
+    const bool barlines_selected =
+        location.hasSelection() && !location.getSelectedBarlines().empty();
 
     myRemoveCurrentSystemCommand->setEnabled(score.getSystems().size() > 1);
     myRemoveCurrentStaffCommand->setEnabled(system.getStaves().size() > 1);
@@ -3883,9 +3885,8 @@ void PowerTabEditor::updateCommands()
                                              Score::MIN_LINE_SPACING);
     myRemoveSpaceCommand->setEnabled(!pos && (position == 0 || !barline) &&
                                      !tempoMarker && !altEnding && !dynamic);
-    myRemoveItemCommand->setEnabled(
-        pos || positions_selected ||
-        canDeleteItem(getCaret().getSelectedItem()));
+    myRemoveItemCommand->setEnabled(pos || positions_selected || barline || barlines_selected ||
+                                    canDeleteItem(getCaret().getSelectedItem()));
     myRemovePositionCommand->setEnabled(pos || positions_selected);
 
     myChordNameCommand->setChecked(

source/score/scorelocation.cpp

@@ -249,7 +249,7 @@ ScoreLocation::getSelectedBarlines()
     // Avoid duplicate logic between const and non-const versions.
     std::vector<const Barline *> barlines = ConstScoreLocation::getSelectedBarlines();
     std::vector<Barline *> nc_barlines;
-    for (const Barline *barline : nc_barlines)
+    for (const Barline *barline : barlines)
         nc_barlines.push_back(const_cast<Barline *>(barline));
 
     return nc_barlines;