Skip to content

Commit

Permalink
add periodSeconds:30 to liveness and readiness probes (#142)
Browse files Browse the repository at this point in the history
* add periodSeconds:30 to liveness and readiness probes to stop pod from restarting before its ready.

* change feature flags to an array and adjust the template

* change feature.flags to list

* fix template

* use range instead of toyaml so we can use squote

* increase probe times to 5
  • Loading branch information
samdulam authored Apr 8, 2024
1 parent 4923718 commit 6f34933
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 6 deletions.
2 changes: 1 addition & 1 deletion charts/portainer/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.

version: 1.0.49
version: 1.0.50

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application.
Expand Down
10 changes: 6 additions & 4 deletions charts/portainer/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,8 @@ spec:
{{- if (and (eq .Values.service.type "NodePort") (not (empty .Values.service.edgeNodePort))) }}
- '--tunnel-port={{ .Values.service.edgeNodePort }}'
{{- end }}
{{- if (not (empty .Values.feature.flags)) }}
- '{{ .Values.feature.flags }}'
{{- range .Values.feature.flags }}
- {{ . | squote }}
{{- end }}
volumeMounts:
{{- if .Values.persistence.enabled }}
Expand Down Expand Up @@ -96,8 +96,9 @@ spec:
containerPort: 8000
protocol: TCP
livenessProbe:
failureThreshold: 3
failureThreshold: 5
initialDelaySeconds: 45
periodSeconds: 30
httpGet:
path: /
{{- if .Values.tls.force }}
Expand Down Expand Up @@ -143,8 +144,9 @@ spec:
{{- end }}
{{- end }}
readinessProbe:
failureThreshold: 3
failureThreshold: 5
initialDelaySeconds: 45
periodSeconds: 30
httpGet:
path: /
{{- if .Values.tls.force }}
Expand Down
2 changes: 1 addition & 1 deletion charts/portainer/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ mtls:
existingSecret: ""

feature:
flags: ""
flags: []

ingress:
enabled: false
Expand Down

0 comments on commit 6f34933

Please sign in to comment.