Added aggregate percentage display based on user preference #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -28,6 +28,13 @@ def index | |||
| description "Gets a clinical quality measure calculation. If calculation is completed, the response will include the results." | |||
| def show | |||
| @qr = QME::QualityReport.find(params[:id]) | |||
|
|
|||
| if ! @qr.aggregatePercentage | |||
|
Please remove tab characters from the code. I understand what you are trying to do here with the aggregate percentage. I'm not sure this is the best way to go about it.
My suggestion would be to just ask for the quality report of the root provider to display as the aggregate. Also, this throws off the alignment of the patients button on CV measures. |
| @@ -16,7 +16,16 @@ | |||
| <div class="denominator">{{formatNumeral fractionBottom '0.[0]a'}}</div> | |||
| </div> | |||
|
|
|||
| <div class="pop-chart pull-left"></div> | |||
| <div class="pop-chart pull-left" style="{{#if showAggregatePercentage}}width:150px !important;{{/if}}"></div> | |||
There was a problem hiding this comment.
Please avoid inline styles, and also please avoid !important rules if possible.
added 25 commits
January 21, 2015 14:19
Provider search / Provider Tree Preference
Upgrade HDS and QME to latest versions
Can change the 1 year reporting period end-date from dashboard
added 26 commits
June 23, 2015 15:23
…, hide measure panel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
selecting measure calculates the percentage for the user and for all the patients in the database (aggregate). User can choose preference for displaying the aggregate measure on the dashboard.